Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORCA-308] Bumps synapseclient and fs-synapse versions & Removes pipenv files #40

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Apr 9, 2024

Description:

This PR bumps up the synapseclient and fs-synapse versions that py-orca depends on.

I also removed Pipfile and Pipfile.lock from the repository. This should have been done as part of #32. Because pipenv does not support constraints files it is impossible to guarantee a consistent installation of apache-airflow in the py-orca development environment. py-orca contributors should rely upon dev_setup.sh to create a virtual environment on their local machines instead.

@BWMac BWMac requested a review from a team as a code owner April 9, 2024 16:49
Copy link

swarmia bot commented Apr 9, 2024

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@BWMac BWMac merged commit 20612c3 into main Apr 19, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/ORCA-308/bump_synapseclient_version branch April 19, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants