AG-1398 fix bug with pValues not showing when value is zero

Sage-Bionetworks · Mar 20, 2024 · ee3310a · ee3310a
1 parent 50a9b1f
commit ee3310a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...ents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.html b/...ents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.html
@@ -15,11 +15,11 @@
     <div class="gct-details-panel-data">
       <div>
         <div>{{ data.valueLabel }}</div>
-        <div *ngIf="data.pValue">P-Value</div>
+        <div>P-Value</div>
       </div>
       <div>
         <div>{{ getSignificantFigures(data.value, 3) }}</div>
-        <div *ngIf="data.pValue">
+        <div>
           {{ getSignificantFigures(data.pValue, 3) }}
         </div>
       </div>

diff --git a/...onents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.ts b/...onents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.ts
@@ -96,6 +96,9 @@ export class GeneComparisonToolDetailsPanelComponent {
   }
 
   getSignificantFigures(n: any, b: any) {
+    const emdash = '&#8212;'; // Shift+Option+Hyphen
+    if (n === null || n === undefined)
+      return emdash;
     return this.helperService.getSignificantFigures(n, b);
   }