Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-703] Validation status with version #574

Merged
merged 16 commits into from
Aug 26, 2024

Conversation

thomasyu888
Copy link
Member

Problem:
Version number wasn't included in the validation status table

Solution:
Add version number. This will be a multi-process PR. We will need to either add new validation status tables, OR edit the schemas.

Extras:
Only download files that need to be validated. This should speed up the download times.

Future work:
Use fileview to get a list of files

@thomasyu888 thomasyu888 changed the title [GEN-703] validation status with version [GEN-703] PoC: validation status with version Jul 9, 2024
@thomasyu888 thomasyu888 changed the title [GEN-703] PoC: validation status with version [GEN-703] Validation status with version Jul 10, 2024
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM! I had a few comments/questions

genie/input_to_database.py Show resolved Hide resolved
tests/test_input_to_database.py Outdated Show resolved Hide resolved
genie/input_to_database.py Outdated Show resolved Hide resolved
Copy link

@thomasyu888 thomasyu888 marked this pull request as ready for review July 16, 2024 04:36
@thomasyu888 thomasyu888 requested a review from a team as a code owner July 16, 2024 04:36
@thomasyu888
Copy link
Member Author

thomasyu888 commented Aug 26, 2024

Trying to figure out what's wrong with the linting... (nevermind, you got it @rxu17 !)

Copy link

@thomasyu888 thomasyu888 merged commit 6ec4fe1 into develop Aug 26, 2024
14 checks passed
@thomasyu888 thomasyu888 deleted the GEN-703-validation-status-with-version branch August 26, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants