Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering function calls and introduce minor updates #9

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Fix filtering function calls and introduce minor updates #9

merged 4 commits into from
Nov 8, 2023

Conversation

pranavanba
Copy link
Collaborator

Major Changes

  1. Pass input, output, and partition arguments when calling functions in filtering step

Minor Changes

  1. Use basename_template for arrow::write_dataset() in filtering step
  2. Ignore files and dirs whose name contain the string "pilot"
  3. Fix variable name reference

@pranavanba pranavanba self-assigned this Nov 8, 2023
@pranavanba pranavanba merged commit 945ad1e into Sage-Bionetworks:main Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pranavanba pranavanba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pranavanba