Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMHDR-251 New ECG Measures for 2024Q2 Release #21

Merged

Conversation

pranavanba
Copy link
Collaborator

@pranavanba pranavanba commented Apr 23, 2024

Major Changes

  1. Implement new process-data steps for fitbitecg and healthkitv2electrocardiogram datasets
    • Only NumRecords is being calculated for the ResultClassification/Classification variables since they are categorical
    • The logic here is based on the other datasets’ processing logic (process-data scripts), so there is no new logic, only applying the same logic to two new datasets

Minor Changes

  1. Update the list of variables to remove from the global environment at the end of certain process-data scripts

@pranavanba pranavanba requested a review from sieberts April 29, 2024 21:15
Copy link

@sieberts sieberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made mostly superficial comments. I presume you've tested this on Pilot Data to make sure it runs and the output is sensible?

scripts/process-data/fitbitecg.R Show resolved Hide resolved
scripts/process-data/healthkitv2electrocardiogram.R Outdated Show resolved Hide resolved
scripts/process-data/fitbitecg.R Outdated Show resolved Hide resolved
scripts/process-data/healthkitv2electrocardiogram.R Outdated Show resolved Hide resolved
scripts/process-data/fitbitecg.R Outdated Show resolved Hide resolved
@pranavanba
Copy link
Collaborator Author

pranavanba commented Apr 30, 2024

I've made mostly superficial comments. I presume you've tested this on Pilot Data to make sure it runs and the output is sensible?

@sieberts Re: testing on pilot data, I created temporary data frames similar to the structure of both prod ECG datasets with just the 3-4 variables needed, and the overall output and content were in the expected format.

@pranavanba pranavanba merged commit 8a3389a into Sage-Bionetworks:main May 1, 2024
2 checks passed
@pranavanba pranavanba deleted the RMHDR-251-new-ecg-measures branch May 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants