-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMHDR-251 New ECG Measures for 2024Q2 Release #21
RMHDR-251 New ECG Measures for 2024Q2 Release #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made mostly superficial comments. I presume you've tested this on Pilot Data to make sure it runs and the output is sensible?
@sieberts Re: testing on pilot data, I created temporary data frames similar to the structure of both prod ECG datasets with just the 3-4 variables needed, and the overall output and content were in the expected format. |
Major Changes
process-data
steps forfitbitecg
andhealthkitv2electrocardiogram
datasetsNumRecords
is being calculated for theResultClassification
/Classification
variables since they are categoricalprocess-data
scripts), so there is no new logic, only applying the same logic to two new datasetsMinor Changes
process-data
scripts