Skip to content

Commit

Permalink
scan again auto-generated files and add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tschaffter committed Apr 9, 2024
1 parent a28c145 commit 23658ee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion apps/openchallenges/challenge-service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ sonar {
property("sonar.host.url", "https://sonarcloud.io")
property("sonar.organization", "sage-bionetworks")
property("sonar.projectKey", "${project.name}")
property("sonar.exclusions", autoGeneratedFiles.join(","))
// We still scan the auto-generated files to be aware of the bugs and code smells they include.
// property("sonar.exclusions", autoGeneratedFiles.join(","))
property("sonar.coverage.exclusions", autoGeneratedFiles.join(","))
// Include the pull request number (ignored if not set)
property("sonar.pullrequest.key", System.getenv('SONAR_PULL_REQUEST_NUMBER'))
Expand Down
6 changes: 4 additions & 2 deletions apps/openchallenges/image-service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,11 @@ sonar {
'**/RFC3339DateFormat.*'
]
properties {
property("sonar.projectKey", "${project.name}")
property("sonar.organization", "sage-bionetworks")
property("sonar.host.url", "https://sonarcloud.io")
property("sonar.organization", "sage-bionetworks")
property("sonar.projectKey", "${project.name}")
// We still scan the auto-generated files to be aware of the bugs and code smells they include.
// property("sonar.exclusions", autoGeneratedFiles.join(","))
property("sonar.coverage.exclusions", autoGeneratedFiles.join(","))
// Include the pull request number (ignored if not set)
property("sonar.pullrequest.key", System.getenv('SONAR_PULL_REQUEST_NUMBER'))
Expand Down

0 comments on commit 23658ee

Please sign in to comment.