AG-1460: improvements from code review

Sage-Bionetworks · Jan 9, 2025 · 9f32839 · 9f32839
1 parent 49ff99c
commit 9f32839
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -56,7 +56,6 @@ service_account.json
 Thumbs.db
 
 .angular
-.yarn
 
 # Gradle
 .gradle

diff --git a/libs/agora/charts/src/lib/box-plot-chart/box-plot-chart.component.ts b/libs/agora/charts/src/lib/box-plot-chart/box-plot-chart.component.ts
@@ -27,7 +27,7 @@ export class BoxPlotComponent {
 
   _data: boxPlotChartItem[] = [];
   points: CategoryPoint[] = [];
-  summaries: CategoryBoxplotSummary[] | undefined = [];
+  summaries: CategoryBoxplotSummary[] = [];
   xAxisCategoryToTooltipText: Record<string, string> | undefined = {};
   isInitialized = false;
   pointTooltipFormatter: ((pt: CategoryPoint) => string) | undefined;
@@ -74,7 +74,7 @@ export class BoxPlotComponent {
         thirdQuartile: item.quartiles[2],
         max: item.value[2],
       };
-      this.summaries?.push(summary);
+      this.summaries.push(summary);
 
       if (this.xAxisCategoryToTooltipText) {
         const tooltipText = this.getXAxisTooltipText(xAxisCategory);
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,7 +56,6 @@ service_account.json @@
     Thumbs.db
     .angular
-    .yarn
     # Gradle
     .gradle
@@ Expand Down @@