fix(openchallenges): challenge card fixes #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaffter
approved these changes
Nov 3, 2023
libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.ts
Outdated
Show resolved
Hide resolved
libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.ts
Outdated
Show resolved
Hide resolved
| @@ -92,7 +98,7 @@ export class ChallengeCardComponent implements OnInit { | |||
| // Find the largest unit of time and return in human-readable format. | |||
| let timeDiffString = ''; | |||
| for (const [unit, value] of Object.entries(timeDiff)) { | |||
| if (unit === 'month' && value > 3) { | |||
| if (hideFarDates && unit === 'month' && value > 3) { | |||
There was a problem hiding this comment.
Far away dates?
Suggested change
| if (hideFarDates && unit === 'month' && value > 3) { | |
| if (hideFarAwayDates && unit === 'month' && value > 3) { |
…omponent.ts Co-authored-by: Thomas Schaffter <[email protected]>
…omponent.ts Co-authored-by: Thomas Schaffter <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
add a new parameter to
calcTimeDiff, so that hiding timeline > 3 months is optionaladd type annotation for return value (feedback)
if an unexpected date format is given, throw an Error instead of returning an empty string (feedback)
Preview
Before
After
