feat(sage-monorepo): create Nx plugin to centralize task definitions #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nx environment fails to initializeRight after opening VS Code. This may also be way the CI workflow currently fail. 
CI error[Nxls] - 2024-10-09T03:49:41.424Z - LoadPluginError: Could not load plugin @sagebionetworks/nx-sage-monorepo
at loadNxPluginAsync (/workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/project-graph/plugins/loader.js:208:15)
at loadNxPlugin (/workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/project-graph/plugins/loader.js:182:9)
at load (/workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker.js:25:65)
at consumeMessage (/workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/project-graph/plugins/isolation/messaging.js:38:32)
at /workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/project-graph/plugins/isolation/plugin-worker.js:21:47
at Socket.<anonymous> (/workspaces/sage-monorepo/node_modules/.pnpm/[email protected]_patch_hash=vxuy2ap6ceuowh22gcuahf5n2m_@[email protected]_@[email protected]_@sw_usm4h2vcgpymoofs5hqaew7zke/node_modules/nx/src/utils/consume-messages-from-socket.js:13:17)
at Socket.emit (node:events:519:28)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
at Readable.push (node:internal/streams/readable:390:5)Related issues |
|
Replaced by #2890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
sage-monorepo/nx-sage-monorepobuild-imageto projects that meet the conditionsbuild-imagefrom theproject.jsonfileslocalandcito the taskbuild-imageof the OC projectsnx.jsonjsonc-eslint-parser(suggested when generating the Nx plugin)nx formatNotes
build-imageto an Angular library does not make sense and even generate error when attempt to runnx run-many --target=build-image --projects=openchallenges-*References
Preview
Generate the Nx plugin
How do I know which task is available for a given project?
nx show project myreactapp --webThis will open the page shown below in your browser.
Docker images build locally
The same images are built compared to before the creation of this PR. What has changed is that the definition of the task
build-imagehas been centralized in a custom Nx plugin.