Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agora): migrate GCT (AG-1602) #2953

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sagely1
Copy link
Contributor

@sagely1 sagely1 commented Dec 19, 2024

Description

Migration of GCT and gene details page
Also migrates charts (except box plot)
miscellaneous fixes (including api)

Existing issues

  • conversion of components to standalone components and lazy-loading has resulted in a bug in the loading overlay component (to be fixed in a future PR)
  • box plot chart utilized in monorepo will be incorporated in a future PR

@tschaffter tschaffter self-requested a review December 19, 2024 15:14
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stack builds and deploys successfully in the local environment. The migration of the app to the monorepo is progressing smoothly.

@tschaffter
Copy link
Member

@sagely1 I will go ahead and merge this PR to make sure it's merged before I'm OOO.

@tschaffter tschaffter merged commit d1534f7 into Sage-Bionetworks:main Dec 19, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants