Update dialup profile #221
Conversation
|
@timvlaer ping |
|
@Salamek this pr is ready for review. I don’t plan any additions. |
huawei_lte_api/api/DialUp.py
Outdated
| ) -> SetResponseType: | ||
| return self._session.post_set('dialup/profiles', { | ||
| 'SetDefault': 1 if is_default else 0, | ||
| 'SetDefault': 0, |
There was a problem hiding this comment.
I'm not sure if it is a good idea to remove is_default parameter and its code, while it does not work for you as expected, it may work for someone else. Also it is BC because someone may call this function with is_default= kwargs or have positional argument there.
We could deprecate this parameter with warning and remove it next minor version but it think that just keeping it there is much less work :-)
There was a problem hiding this comment.
Good point, I’ll revert it
|
@timvlaer ah sorry my bad, i did not post the review... |
|
My apologies, i am abroad right now without computer so I’ll update this PR as soon as i am back home. That will be the 19th of August. |
|
@timvlaer that is completely fine ;-) Enjoy your self. |
|
Reverted the |
While working on the api for dialup profiles, I noticed a few things:
SetDefaultparameter value. I removed the parameter from the function.DialupNum), the request failed with error100001. It looks to me that this field is not optional in my setup... I didn't change this in the code as the example script doesn't have this param so I guess it might work in some cases without dialup_number.ReadOnlyset to2(instead of0for manually created profiles)I tested these things against the api of the Huawei E5576-320, so it might be different on other devices.