Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-17900760@ Deploy Demo Storefront with SLAS Private Client #2297

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from

Conversation

vcua-mobify
Copy link
Collaborator

@vcua-mobify vcua-mobify commented Mar 4, 2025

This PR makes the following changes:

  • A new generator preset has been added for deploying an app using a SLAS private client to https://pwa-kit.mobify-storefront.com/
    • The generator has been added to support features that we want to demo such as multisite
  • Passwordless login, social login, passwordless reset has been enabled on https://pwa-kit.mobify-storefront.com/
  • A new Github Actions workflow has been added to automatically deploy new Github releases to https://pwa-kit.mobify-storefront.com/
  • Cleanup of the check_if_latest_release so that it doesn't produce a failed build when skipping the deployment
  • Newly generated projects will use the SF Cloud as the sample override brand logo.

Testing the changes:
Demo site: https://pwa-kit.mobify-storefront.com/

  • Verify that the site is now using a private SLAS client (check that there is no requests to SLAS /authorize)
  • Verify that passwordless login, social login, and password reset are all working
  • Verify that multisite is working by changing locales and observing translations

Generator:
Run node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --preset retail-react-app-demo-private --outputDir yourOutputDir

CI:
The CI will trigger if you apply a change to this PR branch or if you publish a release that updates the latest release tag.

Here are some sample CI showing the workflow:
CI that deployed a bundle to the demo site - workflow conditions were tweaked to allow this to proceed
CI that did not deploy the demo site when triggered by something other than the latest release being published

@vcua-mobify vcua-mobify added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Mar 4, 2025
@vcua-mobify vcua-mobify changed the title @W-17900760@ WIP - Deploy Demo Storefront with SLAS Private Client @W-17900760@ Deploy Demo Storefront with SLAS Private Client Mar 7, 2025
@vcua-mobify vcua-mobify marked this pull request as ready for review March 7, 2025 00:37
@vcua-mobify vcua-mobify requested a review from a team as a code owner March 7, 2025 00:37
@vcua-mobify vcua-mobify requested a review from bfeister March 7, 2025 00:41
uses: "./.github/actions/push_to_mrt"
with:
CWD: "./packages/template-retail-react-app"
TARGET: production
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this since this is redundant. We are now deploying a preset to the demo site when a new latest release tag is produced.

This does mean that we won't be deploying preview releases onto the live demo site but I can create a different step to handle this if we want.

@vcua-mobify
Copy link
Collaborator Author

vcua-mobify commented Mar 7, 2025

In this slack thread, we have made a conscious decision to use RefArchGlobal as the site along with US as the default locale. To support this, additional changes were made to the zzrf-001 RefArchGlobal locales and currencies. This change is NOT reflected in storefrontdata and will need to be manually re-added if zzrf-001 data is ever reset or if we decide to use an environment other than zzrf-001.

defaultMessage: 'The React PWA Starter Store for Retail',
id: 'home.title.react_starter_store'
})}
{{else}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change here to make it more obvious in the demo site when locale is changed to another language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant