fix: package manager feature #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2024 06:30
techsavvyash
approved these changes
Jun 22, 2024
actions/new.action.ts
Outdated
Comment on lines
557
to
573
| const installNpm = (): void => { | ||
| try { | ||
| const currentPlatform = platform(); | ||
| if (currentPlatform === 'win32') { | ||
| // Windows installation command for npm via Node.js installer | ||
| console.log('Downloading and installing Node.js which includes npm...'); | ||
| execSync('powershell -Command "Invoke-WebRequest -Uri https://nodejs.org/dist/v18.16.1/node-v18.16.1-x64.msi -OutFile nodejs.msi; Start-Process msiexec.exe -ArgumentList \'/i nodejs.msi /quiet\' -Wait; Remove-Item nodejs.msi"', { stdio: 'inherit' }); | ||
| } else { | ||
| // Linux/macOS installation command for npm | ||
| execSync('curl -L https://www.npmjs.com/install.sh | sh', { stdio: 'inherit' }); | ||
| } | ||
| console.log('npm has been installed.'); | ||
| } catch (error) { | ||
| console.error('Failed to install npm:', error); | ||
| process.exit(1); | ||
| } | ||
| }; |
actions/new.action.ts
Outdated
Comment on lines
548
to
555
| const checkIfPackageManagerIsAvailable = (cmd: string): boolean => { | ||
| try { | ||
| execSync(`command -v ${cmd}`, { stdio: 'ignore' }); | ||
| return true; | ||
| } catch (error) { | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
move to npm specific command
There was a problem hiding this comment.
Suggested change
| const checkIfPackageManagerIsAvailable = (cmd: string): boolean => { | |
| try { | |
| execSync(`command -v ${cmd}`, { stdio: 'ignore' }); | |
| return true; | |
| } catch (error) { | |
| return false; | |
| } | |
| }; | |
| execSync(`${cmd} -v`, { stdio: 'ignore' }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #29
Functionality added :
stencil newwill check for installed package managers and then ask user to choose from only those which are installed.Default case: it'll ask to install
npm.Does this PR introduce a breaking change?
Other information