Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload test #187

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

File upload test #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf99b95
fix: uncommented the upload mutiple fn & updated test
Savio629 Sep 25, 2024
903b640
fix: changed public to private readonly
Savio629 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 48 additions & 48 deletions packages/common/src/services/file-upload.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class FileUploadService {
private readonly storage: any;
private readonly storageMode: string;
private readonly useSSL: boolean;
private readonly storageEndpoint: string;
private readonly storageEndpoint: string;
private readonly storagePort: number;
private logger: Logger;

Expand Down Expand Up @@ -219,52 +219,52 @@ export class FileUploadService {
return destination;
}

// async uploadMultiple(
// files: ReadonlyArray<MultipartFile>,
// destination: string,
// filenames: string[],
// ): Promise<string[]> {
// const directories: string[] = [];
async uploadMultiple(
files: MultipartFile[],
destination: string,
filenames: string[],
): Promise<string[]> {
const directories: string[] = [];

// if (!files || files.length == 0) {
// this.logger.error(`Error uploading file: : 'files' field missing`);
// throw new InternalServerErrorException(
// 'File upload failed: files field missing',
// );
// }
// if (!filenames) {
// this.logger.error(`Error uploading file: : 'filenames' field missing`);
// throw new InternalServerErrorException(
// 'File upload failed: filenames field missing',
// );
// }
// if (!Array.isArray(filenames)) {
// filenames = [filenames];
// }
// if (filenames.length != files.length) {
// this.logger.error(
// `Error uploading file: Number of files is not equal to number of filenames`,
// );
// throw new InternalServerErrorException(
// 'File upload failed: Number of files is not equal to number of filenames',
// );
// }
// let c: number = 0;
// for (const file of files) {
// try {
// const fileUploadRequestDto: FileUploadRequestDTO =
// new FileUploadRequestDTO();
// fileUploadRequestDto.file = file;
// fileUploadRequestDto.destination = destination;
// fileUploadRequestDto.filename = filenames[c];
// const directory = await this.upload(fileUploadRequestDto);
// directories.push(directory);
// } catch (error) {
// this.logger.error(`Error uploading file: ${error}`);
// throw new InternalServerErrorException('File upload failed');
// }
// c++;
// }
// return directories;
// }
if (!files || files.length == 0) {
this.logger.error(`Error uploading file: : 'files' field missing`);
throw new InternalServerErrorException(
'File upload failed: files field missing',
);
}
if (!filenames) {
this.logger.error(`Error uploading file: : 'filenames' field missing`);
throw new InternalServerErrorException(
'File upload failed: filenames field missing',
);
}
if (!Array.isArray(filenames)) {
filenames = [filenames];
}
if (filenames.length != files.length) {
this.logger.error(
`Error uploading file: Number of files is not equal to number of filenames`,
);
throw new InternalServerErrorException(
'File upload failed: Number of files is not equal to number of filenames',
);
}
let counter: number = 0;
for (const file of files) {
try {
const fileUploadRequestDto: FileUploadRequestDTO =
new FileUploadRequestDTO();
fileUploadRequestDto.file = file;
fileUploadRequestDto.destination = destination;
fileUploadRequestDto.filename = filenames[counter];
const directory = await this.upload(fileUploadRequestDto);
directories.push(directory);
} catch (error) {
this.logger.error(`Error uploading file: ${error}`);
throw new InternalServerErrorException('File upload failed');
}
counter++;
}
return directories;
}
}
Loading