Return call and response #29
Conversation
readme.md
Outdated
| @@ -14,6 +14,8 @@ FYI: Some terms have the Swedish name in parenthesis and the file names of the s | |||
|
|
|||
| **[3. Statistics](#3-statistics)**: A license portal can fetch data from the producers and present the customer with how many licenses that have been acquired and how many that are actually being used. The data includes information on when the licenses were purchased and when they expire. | |||
|
|
|||
| **[4. Return](#3-return)**: Returns from the reseller's customers to the reseller. The licenses is stored in the reseller's digital warehouse that is provided by the supplier. | |||
There was a problem hiding this comment.
Should be #4
readme.md
Outdated
| | account.organizationNumber | string | x | Organization number | | ||
| | account.name | string | x | Name of the school unit | | ||
| | account.rules | array | | Return rules determined by the reseller and verified by the supplier | | ||
| | rows | array | x| Return rules determined by the reseller and verified by the supplier | |
There was a problem hiding this comment.
Looks like the comment is a copy/paste error from the previous line
readme.md
Outdated
| | licenses.status | string | x | error, ok, rulesBroken. See value list below | | ||
| | licenses.reason | string | | Used with status NotOk | | ||
| | licenses.licenseKey | string | | Licensekey | | ||
| | brokenRule.brokenRules | array | | Array with strings. Can be the same or a subset of the rules sent in the return call. See value list above | |
There was a problem hiding this comment.
should be "licenses.brokenRules"
| | rules | Description | | ||
| | --- | --- | | ||
| | unAssigned | Return allowed only on licenses that are not assigned | | ||
| | notUsed | Return allowed only if the license has not been used | |
There was a problem hiding this comment.
Regading the rules:
If more than one rule is sent, does this mean that it is enough for a license to fulfill only one of the rules, or does it mean that all rules must be fulfilled for the license to be returnable (should the rules be combined with AND or OR)?
What does the specific rules actually mean? Is "notUsed" a license that has never been assigned to a user? Can we change the name of "unAssigned" to "notAssigned" if the meaning is that the license currently isn't assigned to a user?
Is there a need for more rules? Maybe we can discuss this at the next meeting, and add more later?
There was a problem hiding this comment.
Great questions! I think it should be AND? But that can be discussed, and also what kind of rules do we need? Would be good to get more feedback from other suppliers as well.
readme.md
Outdated
| status: "Ok", | ||
| reason: "", | ||
| licenseKey:"235572d0-a26d-4975-97f4-72e4734ff341", | ||
| brokenRules:[]dvs. |
readme.md
Outdated
| licenses: [{ | ||
| orderRowId: "64b879b1-1fdc-4a42-ae7c-b4f9b287a2cc", | ||
| articleNumber: "9789140123456", | ||
| status: "Ok", | ||
| reason: "", | ||
| licenseKey:"235572d0-a26d-4975-97f4-72e4734ff341", | ||
| brokenRules:[] | ||
| },{ | ||
| orderRowId: "64b879b1-1fdc-4a42-ae7c-b4f9b287a2cc", | ||
| articleNumber: "9789140123456", | ||
| status: "NotOk", | ||
| reason: "Returns not allowed after 6 months.", | ||
| licenseKey:"61893cba-5572-458b-ba91-53320be8bb44", | ||
| brokenRules:["unassigned"] | ||
| }] |
There was a problem hiding this comment.
Since the call contains a list of "rows", the response also needs to be a list of rows to enable error-handling per row. This is also how Order and Assignment is specified.
There was a problem hiding this comment.
@oskarsjoberg-sl @fredrikbjurestrom made some changes, please check them out =) rows are now in both call and response.
|
Majema rules: brokenRules: "notAssigned" and "notUsed" |
Should we add a rule for valid length of returns? Like: |
|
Gleerups will not currently be able to support returns via BOL. This as an order may already be invoiced and our system that BOL communicates with does not know if the order has already been invoiced. Gleerups returns must be handled via our support. Here some "rules" that I see could be relevant: |
No description provided.