isfit navbar #1605
Open
isfit navbar #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilte
reviewed
Nov 8, 2024
frontend/src/styles/_z-indexes.scss
Outdated
Comment on lines
18
to
19
| $base-z-index: 0; | ||
| $navbar-z-index: $base-z-index + 1; |
There was a problem hiding this comment.
Kunne muligens vært en liste, så vil en loop sette index automatisk
There was a problem hiding this comment.
Tenkte på det, syntes kanskje det legger på unødvendig kompleksitet?
There was a problem hiding this comment.
Vi har en liten diskusjon rundt et par nivå med z-indexer, istedenfor en sånn her type løsning, typ:
content-z-index: 10
navbar-z-index: 20
modal-z-index: 30
toast-z-index: 40
noe mer?
Også bare forholde oss til disse nivåene. Har du noe innspill på en sånn type løsning, hvor man bare har typ 5 eller 10 alternativ?
andsamfu
reviewed
Nov 14, 2024
| // isfit colors // | ||
| // ---------------- // | ||
| $isfit-primary: rgb(201 31 50); | ||
| $isfit-secondary: #0000ff; |
There was a problem hiding this comment.
Suggested change
| $isfit-secondary: #0000ff; | |
| $isfit-secondary: rgb(0, 153, 204); |
Har du noe fargepalett fra isfit? Ser det har blitt brukt annen blåfarge under headeren.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly isfit navbar