Fix lgtm warnings #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgzf
commented
Oct 7, 2019
js/SisyphusSheep.js
Outdated
| @@ -1140,7 +1140,7 @@ var SisyphusSheepGame = function(){ | |||
| backgroundColor: 0x90a4ae | |||
| }; | |||
|
|
|||
| renderer = PIXI.autoDetectRenderer(rendererOptions); | |||
| var renderer = PIXI.autoDetectRenderer(rendererOptions); | |||
There was a problem hiding this comment.
Why does this break your game? And why does it work without the "var"? And why does your lgtm thing give this as a warning, yet when I do something about it, it breaks your game?
There was a problem hiding this comment.
renderer needs to be global variable to be used by the library
|
This pull request fixes 3 alerts when merging ad786dd into afa94eb - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW I didn't really get to fully test my changes, because I don't think your game is easy run just by running index.html right? Hahaha.