Skip to content

Commit

Permalink
stage2-wasm: enum bigint <= 128 bits
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelverigo authored and SammyJames committed Aug 7, 2024
1 parent 27ca146 commit 08df5e3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
10 changes: 4 additions & 6 deletions src/arch/wasm/CodeGen.zig
Original file line number Diff line number Diff line change
Expand Up @@ -1727,7 +1727,6 @@ fn isByRef(ty: Type, mod: *Module) bool {
.Bool,
.ErrorSet,
.Fn,
.Enum,
.AnyFrame,
=> return false,

Expand All @@ -1750,6 +1749,7 @@ fn isByRef(ty: Type, mod: *Module) bool {
},
.Vector => return determineSimdStoreStrategy(ty, mod) == .unrolled,
.Int => return ty.intInfo(mod).bits > 64,
.Enum => return ty.intInfo(mod).bits > 64,
.Float => return ty.floatBits(target) > 64,
.ErrorUnion => {
const pl_ty = ty.errorUnionPayload(mod);
Expand Down Expand Up @@ -2404,7 +2404,7 @@ fn store(func: *CodeGen, lhs: WValue, rhs: WValue, ty: Type, offset: u32) InnerE
return;
}
},
.Int, .Float => if (abi_size > 8 and abi_size <= 16) {
.Int, .Enum, .Float => if (abi_size > 8 and abi_size <= 16) {
try func.emitWValue(lhs);
const lsb = try func.load(rhs, Type.u64, 0);
try func.store(.{ .stack = {} }, lsb, Type.u64, 0 + lhs.offset());
Expand Down Expand Up @@ -3187,12 +3187,10 @@ fn toTwosComplement(value: anytype, bits: u7) std.meta.Int(.unsigned, @typeInfo(
return @as(WantedT, @intCast(result));
}

/// This function is intended to assert that `isByRef` returns `false` for `ty`.
/// However such an assertion fails on the behavior tests currently.
/// Asserts that `isByRef` returns `false` for `ty`.
fn lowerConstant(func: *CodeGen, val: Value, ty: Type) InnerError!WValue {
const mod = func.bin_file.base.comp.module.?;
// TODO: enable this assertion
//assert(!isByRef(ty, mod));
assert(!isByRef(ty, mod));
const ip = &mod.intern_pool;
if (val.isUndefDeep(mod)) return func.emitUndefined(ty);

Expand Down
1 change: 0 additions & 1 deletion test/behavior/enum.zig
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,6 @@ test "matching captures causes enum equivalence" {
}

test "large enum field values" {
if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest;
if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest;

Expand Down

0 comments on commit 08df5e3

Please sign in to comment.