Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential colorization in stdout export #632

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 11, 2024

Description

Please include a summary of the change and which is fixed.

  • Add colorization for stdout to make review credentials more usability

image

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review December 13, 2024 05:36
@babenek babenek requested a review from a team as a code owner December 13, 2024 05:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (59f6e71) to head (385c0d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
credsweeper/credentials/line_data.py 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   91.37%   91.35%   -0.03%     
==========================================
  Files         146      146              
  Lines        5032     5055      +23     
  Branches      777      784       +7     
==========================================
+ Hits         4598     4618      +20     
- Misses        286      288       +2     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Credential colorization in stdout Credential colorization in stdout export Dec 13, 2024
@babenek babenek marked this pull request as draft December 13, 2024 06:40
@babenek babenek marked this pull request as ready for review December 13, 2024 08:17
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 3938c7d into Samsung:main Dec 13, 2024
32 checks passed
@babenek babenek deleted the colorization branch December 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants