Remove ML_VALIDATION #658
Open
Remove ML_VALIDATION #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babenek
force-pushed
the
no-ml-validation
branch
from
37c2fa3 to
5a6a8e0
Compare
babenek
requested review from
xDizzix,
Yullia,
iuriimet,
tizen-build,
meanrin,
Dmitriy-NK,
silentearth,
csh519 and
kmnls
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 92.23% 92.19% -0.04%
==========================================
Files 135 135
Lines 4918 4909 -9
Branches 800 800
==========================================
- Hits 4536 4526 -10
Misses 241 241
- Partials 141 142 +1 ☔ View full report in Codecov by Sentry. |
csh519
reviewed
Jan 15, 2025
credsweeper/credentials/candidate.py
Outdated
Comment on lines
39
to
41
| # None - ML is applicable but not processed yet; "NA" - ML is not applicable; float - the ml decision | ||
| # Note: -1.0 is possible too for some activation functions in ml model, so let avoid negative values | ||
| self.ml_probability: Union[None, str, float] = None if use_ml else "NA" |
There was a problem hiding this comment.
What about use None not "NA" for ml_probability?
I think "NA" seems better to convey the meaning.
Co-authored-by: ShinHyung Choi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
How has this been tested?
Please describe the tests that you ran to verify your changes.