[onert-micro] Add float BroadcastTo kernels #11633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds float BroadcastTo kernels for onert-micro. ONE-DCO-1.0-Signed-off-by: Artem Balyshev <[email protected]>
mhs4670go
reviewed
Oct 23, 2023
| { | ||
| namespace | ||
| { | ||
| constexpr int kMaxDims = 5; |
There was a problem hiding this comment.
@BalyshevArtem Hello. During working on https://github.com/Samsung/ONE/pull/11701#issuecomment-1774450755, I met a out-bound error on this. Seems that tensorflow supports up to 8 kMaxDims but 8 occurs an error. Could you let me know why you set kMaxDims 5?
There was a problem hiding this comment.
Actually we copy here the behavior of tflite micro: https://github.com/tensorflow/tflite-micro/blob/7ac0b662b6402c1fccc8ec8d1db84f0f34dd4a85/tensorflow/lite/micro/kernels/broadcast_to.cc#L31-L32. Now we do not need to support a larger dimension, since all target models contain a smaller dimension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds float BroadcastTo kernels for onert-micro.
for issue: #10933
ONE-DCO-1.0-Signed-off-by: Artem Balyshev [email protected]