Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tflchef] Introduce extype and custom_code for custom operators #11753

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

Seunghui98
Copy link
Contributor

@Seunghui98 Seunghui98 commented Oct 23, 2023

This introduces extype and custom_code for custom operators.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]


Related Issue: #11741
Draft PR: #11750

@Seunghui98 Seunghui98 self-assigned this Oct 23, 2023
@Seunghui98 Seunghui98 added the PR/ready for review It is ready to review. Please review it. label Oct 23, 2023
This introduces extype and custom_code for custom operators.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
@Seunghui98 Seunghui98 changed the title [tflchef] Introduce a extype of Operation for custom operators [tflchef] Introduce extype and custom_code for custom operators Oct 23, 2023
mhs4670go
mhs4670go previously approved these changes Oct 23, 2023
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type is to be deleted. plz use 99.
if you don't understand why I request with this, plz study about this item.

@Seunghui98
Copy link
Contributor Author

@nnfw-bot test nncc-debug

@Seunghui98
Copy link
Contributor Author

@seanshpark @mhs4670go
As you commended, I modified the code in tflchef and circlechef modules.
Could you review it again??

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit a7bb914 into Samsung:master Oct 24, 2023
3 checks passed
Seunghui98 added a commit to Seunghui98/ONE that referenced this pull request Oct 25, 2023
…ung#11753)

This introduces extype and custom_code for custom operators.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants