Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tflchef] Refactor check_custom_op_value in OpUtils #11854

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

Seunghui98
Copy link
Contributor

This commit is for refactoring check_custom_op_value function in OpUtils.
First, the extype is used for a while and will be removed later.
Second, it is unnecessary to check the state of custom_code because the default value always exists.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]


Related Issue: #11741
Draft PR: #11750

This commit is for refactoring check_custom_op_value function in OpUtils.
First, the extype is used for a while and will be removed later.
Second, it is unnecessary to check the state of custom_code because the default value always exists.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
@Seunghui98 Seunghui98 self-assigned this Nov 1, 2023
@Seunghui98 Seunghui98 added the PR/ready for review It is ready to review. Please review it. label Nov 1, 2023
@Seunghui98
Copy link
Contributor Author

The content of this PR came from the comment.

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Seunghui98
Copy link
Contributor Author

@nnfw-bot test nncc-release

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit ec31785 into Samsung:master Nov 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants