Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tflchef] Remove extype used for custom op #11866

Closed
wants to merge 1 commit into from

Conversation

Seunghui98
Copy link
Contributor

This commit includes removing extype used for custom op because it is no longer necessary.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]


Related Issue: #11741
Draft PR: #11750

@Seunghui98 Seunghui98 added the PR/ready for review It is ready to review. Please review it. label Nov 2, 2023
@Seunghui98 Seunghui98 self-assigned this Nov 2, 2023
@Seunghui98
Copy link
Contributor Author

The order of this PR is the step 4 here.

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark closed this Nov 2, 2023
@seanshpark seanshpark reopened this Nov 2, 2023
@seanshpark
Copy link
Contributor

@hseok-oh , this and #11865 build CI didn't start or finished so I reopened the PRs.
If these are still not finished, can you please take a look?

@seanshpark
Copy link
Contributor

@Seunghui98 , plz check

[2023-11-02T07:38:24.893Z] [libprotobuf ERROR /opt/jenkins_agent/workspace/nnfw/master/pr-nncc-debug@2/externals/PROTOBUF/src/google/protobuf/text_format.cc:288] Error parsing text-format tflchef.ModelRecipe: 29:9: Message type "tflchef.Operation" has no field named "extype".
[2023-11-02T07:38:24.893Z] ERROR: Failed to parse recipe 'All_000.recipe'

This commit includes removing extype used for custom op because it is no longer necessary.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
@mhs4670go
Copy link
Contributor

It doesn't start jenkins CI..

@Seunghui98 Seunghui98 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants