Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT][onert/train] Support AveragePool2D for training #14059

Closed
wants to merge 3 commits into from

Conversation

icodo98
Copy link
Contributor

@icodo98 icodo98 commented Sep 24, 2024

This PR supports AveragePool2D for training

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]

This commit supports AveragePool2D for training

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
@icodo98 icodo98 requested a review from zetwhite September 24, 2024 00:42
@icodo98
Copy link
Contributor Author

icodo98 commented Sep 24, 2024

relatd : #13829

@zetwhite
Copy link
Contributor

zetwhite commented Sep 24, 2024

I didn't read the kernel code yet. But mostly direction looks good to me :)
Could you make PR based on this Draft? I'll read the code details with opened PR.

+) Just for sure, Did you check that a model included AvergePool2D works well?
Ah, I checked your comments here - #13829 (comment).

@zetwhite
Copy link
Contributor

I guess you could split this draft into 2~3 PRs :

  • code under compute/cker, addcker for avgpool
  • code under runtime/onert, support avgpool2d training

@icodo98 icodo98 changed the title [DRAFT][onert/train] support AveragePool2D for training [DRAFT][onert/train] Support AveragePool2D for training Sep 24, 2024
ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
using existing forwarding function for averagePool2D.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants