[onert-micro] Fix training configure tool UB #14406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlavikMIPT
force-pushed
the
onert-micro/train-config/ub-fix
branch
2 times, most recently
from
9111592 to
c7259a1
Compare
This commit fixes undefined behavior in training configure tool. ONE-DCO-1.0-Signed-off-by: Vyacheslav Bazhenov <[email protected]>
SlavikMIPT
force-pushed
the
onert-micro/train-config/ub-fix
branch
from
c7259a1 to
71aa892
Compare
Torrero
approved these changes
Dec 3, 2024
| @@ -32,7 +32,7 @@ void writeTrainConfigFileDataIntoBuffer( | |||
| const auto &train_op_indexes_with_ranks = train_data.trainable_op_indexes_with_ranks; | |||
|
|
|||
| // Resize to calculated size | |||
| auto buffer_size = 8 + train_op_indexes_with_ranks.size() * 2; | |||
| auto buffer_size = 8 + train_op_indexes_with_ranks.size() * 3; | |||
There was a problem hiding this comment.
Could add some comment, please, for explanation of this calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes undefined behavior in training configure tool.
ONE-DCO-1.0-Signed-off-by: Vyacheslav Bazhenov [email protected]