[onert] Relocate API functions #14416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunseoklee
reviewed
Dec 5, 2024
There was a problem hiding this comment.
__API_NNFW_API_INTERNAL_H__ -> __API_NNFW_SESSION_H__ ?
chunseoklee
previously approved these changes
Dec 5, 2024
chunseoklee
previously approved these changes
Dec 6, 2024
This commit relocates API functions - Rename internal API implementation file from nnfw_debug.cc to nnfw_internal.cc - Move some internal API implementation to src/nnfw_internal.cc - Rename nnfw_api_internal.h/cc to nnfw_session.h/cc ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
dismissed stale reviews from chunseoklee, glistening, and zetwhite
via
2691bae
hseok-oh
force-pushed
the
revisit_api_impl
branch
from
f736dff to
2691bae
Compare
|
@chunseoklee @glistening @zetwhite I rebased to resolve conflict. |
chunseoklee
approved these changes
Dec 6, 2024
zetwhite
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relocates API functions
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]