Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci-interpreter] Add check for Reshape #14446

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[luci-interpreter] Add check for Reshape #14446

merged 1 commit into from
Dec 13, 2024

Conversation

jinevening
Copy link
Contributor

@jinevening jinevening commented Dec 13, 2024 •
edited
Loading

This adds a check for num_elements.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]

Related to: #14445

@jinevening
[luci-interpreter] Add check for Reshape
8cc3f04 
This adds a check for num_elements.

ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
@jinevening
Copy link
Contributor Author

jinevening commented Dec 13, 2024 •
edited
Loading

Before this PR, error message is unclear (in the release mode).

munmap_chunk(): invalid pointer

free(): invalid next size (normal)

After this PR, error message is clear.

ERROR: /home/hjj/ONE/compiler/luci-interpreter/src/kernels/Reshape.cpp:81(num_output_elements == num_input_elements) was not true.

seanshpark
seanshpark approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 8869179 into Samsung:master Dec 13, 2024
8 checks passed
@jinevening jinevening deleted the luci-interpreter/reshape_check_numel branch December 13, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark seanshpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinevening @seanshpark