Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle-mlir/models] Introduce Conv2d #14820

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

seanshpark
Copy link
Contributor

This will introduce unit tests for Conv2dOp.

This will introduce unit tests for Conv2dOp.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team March 11, 2025 09:44
Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onnx_opset_version values are different in each file,
11, 12 or 14.
Is this intentional?

@seanshpark
Copy link
Contributor Author

Is this intentional

not sure ...
as noted, I left the version as-is as it's working as expected
and left the verification later;

NOTE our target version is 11, as of now, yes it's old, and have to upgrade to latest someday =_=;

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit 80d2e9d into Samsung:master Mar 12, 2025
5 checks passed
@seanshpark seanshpark deleted the cm_mod_conv2d branch March 12, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants