-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Write comments for Matrix #5358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
June 26, 2023 07:01
Internal API ChangedAdded: 1, Removed: 2, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()
Removed- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)
|
everLEEst
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Write some comments for Matrix / Matrix3 class Signed-off-by: Eunki, Hong <[email protected]>
Internal API ChangedAdded: 2, Removed: 3, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Rotation,Tizen.NUI.Matrix)
Removed- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Matrix,Tizen.NUI.Rotation)
|
hinohie
changed the title
[NUI][WIP] White comments for Matrix
[NUI] Write comments for Matrix
Jun 29, 2023
Internal API ChangedAdded: 3, Removed: 6, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Rotation,Tizen.NUI.Matrix)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Identity()
Removed- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Matrix,Tizen.NUI.Rotation)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::IDENTITY()
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Assign(Tizen.NUI.Matrix)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Assign(Tizen.NUI.Matrix3)
|
Looks Good To Me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write some comments for Matrix / Matrix3 class.