Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Update FontSizeScale values #5369

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Seoyeon2Kim
Copy link
Contributor

Description of Change

  • Except for TV and wearable profiles, FontSizeScale values are updated.

API Changes

  • N/A

Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constant value sync patch. Looks good to me.

private const float FontSizeScaleHuge = 1.9f;
private const float FontSizeScaleGiant = 2.5f;
private const float FontSizeScaleLarge = 1.1f;
private const float FontSizeScaleHuge = 1.12f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.2f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking the value! Fixed it!

- Except for TV and wearable profiles, FontSizeScale values are updated.

Signed-off-by: Seoyeon Kim <[email protected]>
Copy link
Contributor

@jaehyun0cho jaehyun0cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaehyun0cho jaehyun0cho merged commit 73ad9e8 into Samsung:DevelNUI Jul 6, 2023
3 checks passed
@Seoyeon2Kim Seoyeon2Kim deleted the SystemFont branch July 6, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants