-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Update FontSizeScale values #5369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constant value sync patch. Looks good to me.
private const float FontSizeScaleHuge = 1.9f; | ||
private const float FontSizeScaleGiant = 2.5f; | ||
private const float FontSizeScaleLarge = 1.1f; | ||
private const float FontSizeScaleHuge = 1.12f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 1.2f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for checking the value! Fixed it!
- Except for TV and wearable profiles, FontSizeScale values are updated. Signed-off-by: Seoyeon Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
API Changes