Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI.Scene3D] Fix miss used method in SceneView #6351

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[NUI.Scene3D] Fix miss used method in SceneView #6351

merged 1 commit into from
Sep 25, 2024

Conversation

bshsqa
Copy link
Contributor

@bshsqa bshsqa commented Sep 25, 2024

  • DeleteCameraProperty has been used for the case that should use DeleteCamera.

Description of Change

API Changes

  • ACR:

@bshsqa
[NUI.Scene3D] Fix miss used method in SceneView
f2ae0a7 
 - DeleteCameraProperty has been used for the case that should use DeleteCamera.

Signed-off-by: Seungho Baek <[email protected]>
AnglerLee
AnglerLee approved these changes Sep 25, 2024
View reviewed changes
Copy link

@AnglerLee AnglerLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue of using DeleteCameraProperty instead of DeleteCamera in SceneView has been fixed. Thank you for your hard work.

hinohie
hinohie approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@hinohie hinohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for find it. It would be hard to found it in future :D

tscholb
tscholb approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@tscholb tscholb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bshsqa bshsqa merged commit c3d5df3 into Samsung:DevelNUI Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinohie hinohie hinohie approved these changes

@tscholb tscholb tscholb approved these changes

@AnglerLee AnglerLee AnglerLee approved these changes

Assignees
No one assigned
Labels
Devel-NUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bshsqa @hinohie @tscholb @AnglerLee