[Applications.ComponentBased] Enhance API descriptions #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 1Changed- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
System.Boolean Tizen.Applications.ComponentBased.Common.ServiceComponent::OnCreate()
|
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 1Changed- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
System.Boolean Tizen.Applications.ComponentBased.Common.ServiceComponent::OnCreate()
|
hjhun
reviewed
Sep 26, 2024
| /// <returns>True if a service component is successfully created</returns> | ||
| /// <returns> | ||
| /// <c>true</c> if the service component is successfully created; otherwise, <c>false</c>. | ||
| /// </returns> | ||
| public abstract bool OnCreate(); |
There was a problem hiding this comment.
Please add a missing since tag.
There was a problem hiding this comment.
When I added the since tag, the ACR-Required tag was added.
So I kept it as before.
There was a problem hiding this comment.
I think we can ignore ACR-Requried. Because, the tag was added when ACR was accepted.
There was a problem hiding this comment.
Ok I see. I'll prepare the patch.
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 1Changed- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
System.Boolean Tizen.Applications.ComponentBased.Common.ServiceComponent::OnCreate()
|
hjhun
approved these changes
Sep 27, 2024
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 1Changed- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
System.Boolean Tizen.Applications.ComponentBased.Common.ServiceComponent::OnCreate()
|
Signed-off-by: Changgyu Choi <[email protected]>
Signed-off-by: upple <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Enhance API descriptions
API Changes