This repository was archived by the owner on Dec 1, 2020. It is now read-only.
IPv4 only support for some UDP features at TizenRT #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See: |
|
Please fix the DCO in the commit message. |
|
@pmarcinkiew rebase please |
pmarcinkiew
force-pushed
the
dgram_ttl_loop
branch
2 times, most recently
from
3e9a9ce to
b38b835
Compare
|
Could you merge this PR? |
LaszloLango
suggested changes
Sep 7, 2017
src/unix/udp.c
Outdated
| * than not being able to set TTL at all for. | ||
| */ | ||
| static int get_ipv6_unicast_hops() { | ||
| return -1; |
src/unix/udp.c
Outdated
| return -1; | ||
| } | ||
| static int get_ipv6_multicast_hops() { | ||
| return -1; |
src/unix/udp.c
Outdated
| return -1; | ||
| } | ||
| static int get_ipv6_multicast_loop() { | ||
| return -1; |
src/unix/udp.c
Outdated
| } | ||
| #else | ||
| static int get_ipv6_unicast_hops() { | ||
| return IPV6_UNICAST_HOPS; |
src/unix/udp.c
Outdated
| return IPV6_UNICAST_HOPS; | ||
| } | ||
| static int get_ipv6_multicast_hops() { | ||
| return IPV6_MULTICAST_HOPS; |
src/unix/udp.c
Outdated
| return IPV6_MULTICAST_HOPS; | ||
| } | ||
| static int get_ipv6_multicast_loop() { | ||
| return IPV6_MULTICAST_LOOP; |
src/unix/udp.c
Outdated
| } else { | ||
| assert(0 && "unexpected address family"); | ||
| abort(); | ||
| } | ||
|
|
||
| return 0; | ||
| } | ||
| #endif | ||
|
|
||
|
|
There was a problem hiding this comment.
Unnecessary empty lines
src/unix/udp.c
Outdated
| static int get_ipv6_multicast_loop() { | ||
| return IPV6_MULTICAST_LOOP; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
#endif /* defined(__TIZENRT__) */
pmarcinkiew
force-pushed
the
dgram_ttl_loop
branch
from
b38b835 to
4c9d04c
Compare
Several UDP features were enabled for IPv4 only implementations in Nuttx/TizenRT. libtuv-DCO-1.0-Signed-off-by: Piotr Marcinkiewicz [email protected]
pmarcinkiew
force-pushed
the
dgram_ttl_loop
branch
from
4c9d04c to
c3ff295
Compare
LaszloLango
reviewed
Sep 8, 2017
| } | ||
| #else | ||
| static int get_ipv6_unicast_hops() { | ||
| return IPV6_UNICAST_HOPS; |
There was a problem hiding this comment.
#93 introduced these macros. Wouldn't be better to change them to -1 at line 72:80?
|
In my opinion #93 solves issue I was investigating. Let's close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several UDP features were enabled for IPv4 only implementations in TizenRT.
Enabled functions:
uv_udp_set_ttl, uv_udp_set_multicast_ttl, uv_udp_set_multicast_loop, uv_udp_set_multicast_interface