Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dupe word typos #1037

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix dupe word typos #1037

merged 1 commit into from
Sep 5, 2023

Conversation

Rageking8
Copy link
Contributor

No description provided.

@SanderMertens
Copy link
Owner

Wow how did you find all of those 😀 Thanks for the PR!

@SanderMertens SanderMertens merged commit ec237bf into SanderMertens:master Sep 5, 2023
@Rageking8
Copy link
Contributor Author

Wow how did you find all of those 😀 Thanks for the PR!

Haha. I found those using a crude regex search across the whole codebase targeting a common typo where one repeats a word twice when only one is intended.

@Rageking8
Copy link
Contributor Author

flecs/flecs.h

Line 27544 in ec237bf

filter() : filter_base() { } // necessary not not confuse msvc

flecs/include/flecs/addons/cpp/mixins/filter/impl.hpp

Line 141 in ec237bf

filter() : filter_base() { } // necessary not not confuse msvc

Left out some that I was unsure on, such as the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rageking8 @SanderMertens