-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] operator== hook #1455
Open
jpeletier
wants to merge
23
commits into
SanderMertens:master
Choose a base branch
from
vworlds:equals-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[core] operator== hook #1455
+7,211
−1,306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeletier
force-pushed
the
equals-hook
branch
from
December 4, 2024 22:43
aa9a740
to
5f7fe2a
Compare
Allow in cpp to generate equals hook from compare hook
jpeletier
force-pushed
the
equals-hook
branch
5 times, most recently
from
December 5, 2024 16:48
38dce50
to
fa1a619
Compare
jpeletier
force-pushed
the
equals-hook
branch
from
December 5, 2024 17:01
fa1a619
to
2c416ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, requires #1454 to be merged first.
Building on the previous PR, this one adds a hook for
operator==
. It will detect this operator in a component definition and bind a hook to it that can be used to test components for equality.If this operator is not defined but the compare operator is, Flecs will automatically derive this operator.