Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the BAZEL build to work with the new code, and on Windows. #566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mason-bially
Copy link
Contributor

@mason-bially mason-bially commented Nov 30, 2021

Updating the bazel build files to support version 3. I can fix up the example once it's officially released.

So some issues with this build.

I can't put the BUILD file in just the root. This breaks Windows/MSVC due to how it likes to resolve #include dependencies (because there is a flecs.h in the root folder). I also can't put an alias there to enable @flecs resolving correctly because for whatever reason building //src:flecs from the root folder also breaks it. Something is wrong in bazel's sandboxing in windows for this specific situation (code at the root).

Some tests are not passing on windows. Notably these won't even build because MSVC does not support C99.

test/api/src/Filter.c(789): error C2059: syntax error: '}'
test/api/src/Filter.c(822): error C2059: syntax error: '}'
test/api/src/Filter.c(859): error C2059: syntax error: '}'
test/api/src/Filter.c(984): error C2059: syntax error: '}'
test/api/src/Filter.c(1044): error C2059: syntax error: '}'

test/api/src/OnDelete.c(717): error C2057: expected constant expression
test/api/src/OnDelete.c(717): error C2466: cannot allocate an array of constant size 0
test/api/src/OnDelete.c(717): error C2133: 'r': unknown size
test/api/src/OnDelete.c(748): error C2057: expected constant expression
test/api/src/OnDelete.c(748): error C2466: cannot allocate an array of constant size 0
test/api/src/OnDelete.c(748): error C2133: 'r': unknown size
test/api/src/OnDelete.c(1025): error C2057: expected constant expression
test/api/src/OnDelete.c(1025): error C2466: cannot allocate an array of constant size 0
test/api/src/OnDelete.c(1025): error C2133: 'objects': unknown size

test/api/src/Rules.c(32): error C2059: syntax error: '}'
test/api/src/Rules.c(4227): error C2059: syntax error: '}'

test/api/src/Entity.c(718): error C2059: syntax error: '}'
test/api/src/Entity.c(757): error C2059: syntax error: '}'

@mason-bially
Copy link
Contributor Author

mason-bially commented Dec 3, 2021

@SanderMertens I'm not sure why the CI is failing, appears to be a bake issue? I don't think I'm effecting it.

This should conform closer to what you want the bazel build to look like.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SanderMertens SanderMertens force-pushed the master branch 2 times, most recently from 0b0631f to c4b01f9 Compare August 29, 2023 00:35
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 438bde4 to 220852f Compare December 13, 2023 23:59
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 3b99938 to ac6cdca Compare February 20, 2024 08:24
@SanderMertens SanderMertens force-pushed the master branch 8 times, most recently from ace232e to b968586 Compare March 13, 2024 18:12
@SanderMertens SanderMertens force-pushed the master branch 3 times, most recently from 301243a to 4a5784f Compare April 23, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants