Embed Carla windows into UI on Linux by implementing a Wayland compositor #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
- Coverage 70.27% 70.20% -0.08%
==========================================
Files 247 249 +2
Lines 25039 25150 +111
==========================================
+ Hits 17596 17656 +60
- Misses 7443 7494 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins each having their own window is already a bit messy sometimes.
But the clutter gets more frustrating because each FX chain has its own Carla instance, which has its own window as well (and they al look alike).
By implementing a Wayland compositor, we can embed the carla windows in our UI to reduce the clutter. For now, the plugins themselves won't all work on Wayland so we leave them in their own windows.