Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-sos as a submodule #1106

Merged
merged 22 commits into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7af5fd4
Add test-sos as a submodule
kholland-intel Nov 14, 2023
4ac55af
Updated CI to install submodule
kholland-intel Nov 16, 2023
ce94209
CI: move "submodules: true" to the top of each job
Nov 16, 2023
e081eeb
Update Error message in autogen
kholland-intel Nov 16, 2023
a2643b7
Re-add tests-sos submodule to track main branch
kholland-intel Nov 17, 2023
c09cb26
Removed submodule
kholland-intel Nov 20, 2023
e938972
Correctly tracking branch in submodule
kholland-intel Nov 20, 2023
d52236d
Fix SOS RPM Bug
kholland-intel Nov 27, 2023
fe6441f
Fix RPM CI row and update scripts
kholland-intel Nov 29, 2023
67005b8
Update autogen file to check test directory for Makefiles
kholland-intel Nov 29, 2023
ef91a6b
Fixed autogen formatting
kholland-intel Dec 5, 2023
0417d08
tests-sos: change submodule to use a relative path
Feb 7, 2024
f40ea8b
tests-sos: have autogen.sh copy test-sos submodule
Feb 7, 2024
1a2c6df
CI: remove UCX pmi-mpi testing row (See #1048)
Feb 7, 2024
cd9bbac
Merge branch 'main' into pr/test-submodule
Feb 7, 2024
48cbd79
tests-sos: remove copy, point directly to module
Feb 8, 2024
469d6da
tests-sos: revert symlink file deletion
Feb 8, 2024
e520616
CI: fixup tests symlink for tests-sos submodule
Feb 8, 2024
b5eca1c
CI: remove UCX pmi-mpi testing row (See #1048)
Feb 7, 2024
c3829ef
tests-sos: readd submodule tracking main branch
Feb 8, 2024
86fca89
tests-sos: patch RPM build and remove test symlink
Feb 14, 2024
989d8d3
tests-sos: update submodule to latest 'main'
Feb 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ jobs:
- name: Checking OS version
run: |
echo "OS_NAME=$(lsb_release -si)-$(ls_release -sr)" >> $GITHUB_ENV
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: 'true'
- name: Install dependencies
run: |
sudo apt-get install -y gfortran rpm mpich libmpich-dev libhwloc-dev
Expand All @@ -167,7 +169,7 @@ jobs:
key: libfabric-${{ matrix.libfabric_version }}-${{ env.OS_NAME }}
- name: Checkout libfabric
if: steps.cache-libfabric.outputs.cache-hit != 'true'
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: ofiwg/libfabric
path: repos/libfabric
Expand All @@ -192,7 +194,7 @@ jobs:
key: xpmem-${{ matrix.xpmem_version }}-${{ env.OS_NAME }}
- name: Checkout XPMEM
if: ${{ matrix.xpmem_version }}
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: hjelmn/xpmem
path: repos/xpmem
Expand Down Expand Up @@ -232,6 +234,8 @@ jobs:
#make dist
#rpmbuild -ta ./sandia-openshmem-*.tar.gz --define "configargs --with-ofi=${LIBFABRIC_INSTALL_DIR} ${{ matrix.sos_config }}" --define "_prefix /usr/shmem"
#make clean
rm test
davidozog marked this conversation as resolved.
Show resolved Hide resolved
cp -r modules/tests-sos/test test
./configure --with-ofi=${LIBFABRIC_INSTALL_DIR} ${{ matrix.sos_config }}
make dist
rpmbuild -ta ./sandia-openshmem-*.tar.gz --define "configargs --with-ofi=${LIBFABRIC_INSTALL_DIR} ${{ matrix.sos_config }}"
Expand Down Expand Up @@ -483,7 +487,9 @@ jobs:
- name: Checking OS version
run: |
echo "OS_NAME=$(lsb_release -si)-$(ls_release -sr)" >> $GITHUB_ENV
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: 'true'
- name: Install dependencies
run: |
sudo apt-get install -y gfortran mpich libmpich-dev
Expand All @@ -492,7 +498,7 @@ jobs:

# XPMEM
- name: Checkout XPMEM
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: hjelmn/xpmem
path: repos/xpmem
Expand All @@ -517,7 +523,7 @@ jobs:
key: ucx-${{ matrix.ucx_version}}-${{ env.OS_NAME }}
- name: Checkout UCX
if: steps.cache-ucx.outputs.cache-hit != 'true'
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: openucx/ucx
path: repos/ucx
Expand Down Expand Up @@ -573,7 +579,9 @@ jobs:
- name: Checking OS version
run: |
echo "OS_NAME=$(lsb_release -si)-$(ls_release -sr)" >> $GITHUB_ENV
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: 'true'
- name: Install dependencies
run: |
sudo apt-get install -y gfortran mpich libmpich-dev libev-dev libev-libevent-dev
Expand All @@ -582,7 +590,7 @@ jobs:

# XPMEM
- name: Checkout XPMEM
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: hjelmn/xpmem
path: repos/xpmem
Expand All @@ -607,7 +615,7 @@ jobs:
key: portals4-${{ matrix.portals4_version}}-${{ env.OS_NAME }}
- name: Checkout Portals4
if: steps.cache-portals4.outputs.cache-hit != 'true'
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: regrant/portals4
path: repos/portals4
Expand Down Expand Up @@ -650,7 +658,9 @@ jobs:
- name: Checking OS version
run: |
echo "OS_NAME=$(lsb_release -si)-$(ls_release -sr)" >> $GITHUB_ENV
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: 'true'
- name: Install dependencies
run: |
sudo apt-get install -y gfortran mpich libmpich-dev libev-dev libev-libevent-dev
Expand All @@ -659,7 +669,7 @@ jobs:

# XPMEM
- name: Checkout XPMEM
uses: actions/checkout@v2
uses: actions/checkout@v4
wrrobin marked this conversation as resolved.
Show resolved Hide resolved
with:
repository: hjelmn/xpmem
path: repos/xpmem
Expand Down
4 changes: 4 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[submodule "modules/tests-sos"]
path = modules/tests-sos
url = [email protected]:openshmem-org/tests-sos.git
branch = main
davidozog marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 8 additions & 0 deletions autogen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

test -d ./config || mkdir ./config

if [ ! -f test/Makefile.am ] || [ ! -f test/apps/Makefile.am ] ||
[ ! -f test/include/Makefile.am ] || [ ! -f test/performance/Makefile.am ] ||
[ ! -f test/shmemx/Makefile.am ] || [ ! -f test/spec-example/Makefile.am ] ||
[ ! -f test/unit/Makefile.am ];
then
test -f modules/tests-sos/autogen.sh || { echo "ERROR: The test directory is empty. Please run the following command to download the SOS tests:"; echo "git submodule update --init"; exit 1; }
wrrobin marked this conversation as resolved.
Show resolved Hide resolved
fi

FILES=./man/*.1
echo -n "dist_man1_MANS =" > ./man/Makefile.am
for f in $FILES
Expand Down
1 change: 1 addition & 0 deletions modules/tests-sos
Submodule tests-sos added at d52b3f
2 changes: 1 addition & 1 deletion scripts/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ RUN make install

# Build SOS
WORKDIR $SOS_INSTALL
RUN git clone https://github.com/Sandia-OpenSHMEM/SOS.git
RUN git clone --recurse-submodules https://github.com/Sandia-OpenSHMEM/SOS.git
WORKDIR SOS
RUN ./autogen.sh
# To build SOS w/ basic Libfabric
Expand Down
2 changes: 1 addition & 1 deletion scripts/simple-build-ofi.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ echo ========================================================================
echo = BUILDING SANDIA OPENSHMEM
echo ========================================================================

git clone -b $SOS_VERSION --depth $CLONE_DEPTH https://github.com/Sandia-OpenSHMEM/SOS.git sos
git clone -b $SOS_VERSION --depth $CLONE_DEPTH --recurse-submodules https://github.com/Sandia-OpenSHMEM/SOS.git sos
cd sos
./autogen.sh
./configure --prefix=$INSTALL_DIR --with-ofi=$INSTALL_DIR $SOS_CONFIG_OPTS
Expand Down
1 change: 1 addition & 0 deletions test
14 changes: 0 additions & 14 deletions test/Makefile.am

This file was deleted.

58 changes: 0 additions & 58 deletions test/apps/Makefile.am

This file was deleted.

82 changes: 0 additions & 82 deletions test/apps/binary-search.c

This file was deleted.

Loading
Loading