Signal set add APIs #1109
Signal set add APIs #1109
Conversation
There was a problem hiding this comment.
Looks great, but maybe the tests should go into test/shmemx? We've recently organized the tests in that manner to better support other libraries that might not have newer APIs like this.
Also, I wonder if it would be easier to handle this change after our upcoming "tests-sos as a submodule" change in #1106... perhaps we can discuss offline.
| @@ -700,6 +708,52 @@ shmem_signal_fetch(const uint64_t* sig_addr) | |||
| return val; | |||
| } | |||
|
|
|||
| void SHMEM_FUNCTION_ATTRIBUTES | |||
| shmemx_signal_add(uint64_t *sig_addr, uint64_t signal, int pe) | |||
There was a problem hiding this comment.
Should sig_addr be const? I know in the PR where this was added in the spec the change was suggested to remove the const modifier from sig_addr, but it looks like in the main branch of the OpenSHMEM spec repo it is still a const parameter
| } | ||
|
|
||
| void SHMEM_FUNCTION_ATTRIBUTES | ||
| shmemx_signal_set(uint64_t *sig_addr, uint64_t signal, int pe) |
There was a problem hiding this comment.
Same question about const-ness of sig_addr
|
Stale. Closing and opening a new one. |
This PR adds the APIs proposed in openshmem-org/specification#489