Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pedantic compiler warnings #1133

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix pedantic compiler warnings #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mpp/shmemx_c_func.h4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,6 @@ SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_ctx_signal_set(shmem_ctx_t ctx, uin

/* Separate initializers */
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_heap_create(void *base, size_t size, int device_type, int device_index);
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_heap_preinit();
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_heap_preinit(void);
SHMEM_FUNCTION_ATTRIBUTES int SHPRE()shmemx_heap_preinit_thread(int requested, int *provided);
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_heap_postinit();
SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmemx_heap_postinit(void);
2 changes: 1 addition & 1 deletion src/shmem_team.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ int shmem_internal_team_split_strided(shmem_internal_team_t *parent_team, int PE

shmem_internal_team_release_psyncs(parent_team, SYNC);

/* This OR reduction assures all PEs return the same value. */
/* This MAX reduction assures all PEs return the same value. */
psync = shmem_internal_team_choose_psync(parent_team, REDUCE);

shmem_internal_op_to_all(team_ret_val_reduced, team_ret_val, 1, sizeof(int),
Expand Down
2 changes: 2 additions & 0 deletions src/transport_ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,6 +1348,7 @@ int allocate_fabric_resources(struct fabric_info *info)
}

#ifdef USE_HWLOC
static inline
struct fi_info *assign_nic_with_hwloc(struct fi_info *fabric, struct fi_info **provs, size_t num_nics) {
int ret = 0;
hwloc_bitmap_t bindset = hwloc_bitmap_alloc();
Expand Down Expand Up @@ -1420,6 +1421,7 @@ static int compare_nic_names(const void *f1, const void *f2)
return strcmp((*fabric1)->nic->device_attr->name, (*fabric2)->nic->device_attr->name);
}

static inline
bool nic_already_used(struct fid_nic *nic, struct fi_info *fabrics, int num_nics)
{
struct fi_info *cur_fabric = fabrics;
Expand Down
Loading