#67 Fixed syntax errors

[bibekpanda55]

What type of PR is this? (check all applicable)

• Refactor
• Optimization

Description

Featured Covered in this PR

-Fixed syntax errors across files after running bash pre-commit

Related Tickets & Documents

• Related Issue Need help with fixing syntax errors!! #67
• Closes Need help with fixing syntax errors!! #67

Screenshots, Recordings

Have attached screenshot after resolving all the syntax errors and then running the command bash pre-commit.

Tested Feature??

[bibekpanda55]

@micedreams @SankethBK Please check this PR and merge it if you don't find any issues. That would help. Thanks

[SankethBK]

@bibekpanda55 let's avoid making changes inside packages as it could create bugs and makes it difficult to update packages.

We can add this in analysis_options.yaml to ignore linting for packages folder ref

analyzer:
  exclude:
    - packages/**

[bibekpanda55]

@SankethBK The issue stated to solve all syntax errors that shows on running the bash pre-commit command. It didn't specify not to make changes to any particular folder or file. So I worked accordingly.

[SankethBK]

Sure, @bibekpanda55 , thanks for the contribution. Merging this to a temporary branch as we need some changes in analysis_options.yaml. I'll create new issue for this

[bibekpanda55]

@SankethBK I could have added that line analysis_options.yaml file that was not an issue. I thought you were asking to revert back the changes made in all files under packages folder.

[SankethBK]

yes, we need to revert the changes in the packages folder as well, as commenting code in package might break some functionality. It's fine as we didn't mention this in the issue earlier

[bibekpanda55]

Got it. Still have created a PR after changing the analysis_options.yaml file as you said in the fix_linter_errors branch

[SankethBK]

Thank you, merged it