Skip to content

Commit

Permalink
refactor structure
Browse files Browse the repository at this point in the history
  • Loading branch information
Sansui233 committed Apr 5, 2024
1 parent 96e3daa commit b566670
Show file tree
Hide file tree
Showing 5 changed files with 281 additions and 251 deletions.
2 changes: 1 addition & 1 deletion custom.css

Large diffs are not rendered by default.

24 changes: 24 additions & 0 deletions docs/compability-for-accent-color.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
## Compability for accent color (to theme developer)

Color pallete variable structure.

```
Light mode
└ Common style
└ Accent color specific
└ Default logseq color specific (also as fallback)
```

And the same as dark mode.

Notice that accent color design system use a fixed color variable from color pallete ahead of all self-defined variables. which makes it hard to overwrite color in accent color mode with good compability.

There are two ways of overwriting:

1. Overwrite dom style. Turn it back to self-defined variable first as old design does. It requires a constant alignment with Logseq's new design and the custom-theme will be in frequent update.
2. Write the full self-defined color pallete. This requires a large amount of code and introduces additional performance overhead, which may not be desirable for a custom-theme.

And, here's the third way:

- Give up adaption of accent color.

Loading

0 comments on commit b566670

Please sign in to comment.