Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polydispersity limits is incorrectly set in bumps_model.py #606

Open
XaelShan opened this issue Aug 5, 2024 · 0 comments · May be fixed by #627
Open

Polydispersity limits is incorrectly set in bumps_model.py #606

XaelShan opened this issue Aug 5, 2024 · 0 comments · May be fixed by #627

Comments

@XaelShan
Copy link

XaelShan commented Aug 5, 2024

Right now the limits for _pd is set as
pars[p.name].limits
which forces the user to set their own limits for _pd. Should be setting the limits as sasview polydispersity defaults.
pkienzle pushed a commit that referenced this issue Jan 21, 2025
See pd limits to match sasview. Fixes #606.
805009d
@pkienzle pkienzle linked a pull request Jan 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set pd limits to match sasview SasView/sasmodels
1 participant
@XaelShan