Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pd limits to match sasview #627

Open
wants to merge 1 commit into
base: release_1.0.9
Choose a base branch
from
Open

Set pd limits to match sasview #627

wants to merge 1 commit into from

Conversation

pkienzle
Copy link
Contributor

Fixes #606

Check by running the bumps GUI with model example/fit.py:

python -m bumps.cli example/fit.py core_shell_cylinder --edit

Toggling length_pd and theta_pd fitting should give the limits as the parameter defaults.

Note: the --edit option only works if you have wx in your python environment.

@pkienzle pkienzle changed the title See pd limits to match sasview Set pd limits to match sasview Jan 21, 2025
@krzywon krzywon changed the base branch from master to release_1.0.9 January 22, 2025 19:41
@krzywon
Copy link
Collaborator

krzywon commented Jan 28, 2025

Lower priority for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SasModels 1.0.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polydispersity limits is incorrectly set in bumps_model.py
2 participants
@pkienzle @krzywon