Fix errors due to scipy 1.15 release #621
Conversation
|
Note that romberg has been dropped from scipy integrate so this was replaced by quad in the validation tests, but quad doesn't converge so the tests fail. These are slow validation tests that do not need to be run during CI, so suppress them for now. This does not change test coverage. Consider moving the validation tests to the "explore" directory with other validation code. Revisit when we address #568. |
| @@ -874,7 +874,8 @@ def test_cylinder(): | |||
| """ | |||
| Cylinder = _make_standard_model('cylinder') | |||
| cylinder = Cylinder() | |||
| return cylinder.evalDistribution([0.1, 0.1]) | |||
| # Smoke test: does it run without error? | |||
| cylinder.evalDistribution([0.1, 0.1]) | |||
There was a problem hiding this comment.
Do you not want to assert a known, expected returned value for evalDistribution here?
pytest.ini
Outdated
| @@ -2,6 +2,6 @@ | |||
| addopts = --doctest-modules | |||
| doctest_optionflags = ELLIPSIS | |||
| testpaths = sasmodels | |||
| python_files = *.py | |||
| python_files = doc/**/*.py example/**/*.py sasmodels/**/*.py | |||
There was a problem hiding this comment.
I think is a good idea - seems appropriate to test the python files in this library, not every library that this library uses.
|
After removing doc from the glob I tried to make sure that doctests were still being run on the rst files in the doc directory. Turns out that they aren't, and there aren't any except for a spurious shell command doc written as |
Fixes #618