Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round to nearest integer for star polymer arms. #631

Open
wants to merge 4 commits into
base: 306_star_polymer
Choose a base branch
from

Conversation

pkienzle
Copy link
Contributor

Fixes #298.

This is a breaking change. Preexisting models with non-integer number of arms will silently return a new value.

The choice of rounding means that the both end points (currently 1 and 6 arms) will be processed correctly.

The parameter arms can only be fit by an optimizer that can handle the step function, such as DREAM.

@pkienzle
Copy link
Contributor Author

Note there is a little bit of inconsistency in the parameter names. Should be n_arms to match integer parameters in other models. Similarly num_pearls to n_pearls in the pearl necklace and linear pearls model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant