Skip to content

Commit

Permalink
Merge branch '2663-update-nomenclature-for-sesans-plots' of https://g…
Browse files Browse the repository at this point in the history
…ithub.com/SasView/sasview into 2663-update-nomenclature-for-sesans-plots
  • Loading branch information
caitwolf committed Mar 12, 2024
2 parents f7dcb60 + 86dcd05 commit 4ae3ed5
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 17 deletions.
25 changes: 16 additions & 9 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,20 @@ Fixes # (issue/issues)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

## Review Checklist (please remove items if they don't apply):

- [ ] Code has been reviewed
- [ ] Functionality has been tested
- [ ] Windows installer (GH artifact) has been tested (installed and worked)
- [ ] MacOSX installer (GH artifact) has been tested (installed and worked)
- [ ] User documentation is available and complete (if required)
- [ ] Developers documentation is available and complete (if required)
- [ ] The introduced changes comply with SasView license (BSD 3-Clause)
## Review Checklist:

[if using the editor, use `[x]` in place of `[ ]` to check a box]

**Documentation** (check at least one)
- [ ] There is **nothing** that needs documenting
- [ ] Documentation changes are **in this PR**
- [ ] There is an **issue** open for the documentation (link?)

**Installers**
- [ ] There is a chance this will affect the **installers**, if so
- [ ] **Windows** installer (GH artifact) has been tested (installed and worked)
- [ ] **MacOSX** installer (GH artifact) has been tested (installed and worked)

**Licencing** (untick if necessary)
- [x] The introduced changes comply with SasView license (BSD 3-Clause)

10 changes: 3 additions & 7 deletions build_tools/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,12 @@ tinycc
h5py
sphinx
pyparsing
html5lib
pybind11
html5lib
appdirs
six
numba
mako
numba
ipython
qtconsole
xhtml2pdf
pylint
xhtml2pdf
periodictable
uncertainties
matplotlib
Expand Down
4 changes: 3 additions & 1 deletion src/sas/qtgui/MainWindow/DataExplorer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,9 @@ def closeAllPlots(self):
"""
Close all currently displayed plots
"""

# results panel
self.parent.results_frame.setVisible(False)
# plots
for plot_id in PlotHelper.currentPlotIds():
try:
plotter = PlotHelper.plotById(plot_id)
Expand Down

0 comments on commit 4ae3ed5

Please sign in to comment.