Fixed unmatched method signatures in Box&Wedge Interactor child classes #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpotrzebowski
added
the
Discuss At The Call
|
@wpotrzebowski What did we say was needed here? |
|
Did we just say we'd close it as it has been superceded? @ehewins @wpotrzebowski |
|
Nope @lucas-wilkins , the PR which needed closing already has been closed. This one should be merged please. |
wpotrzebowski
added
Discuss At The Call
|
It is not related to this PR but I noticed that labels on the plot for the initial values of slicers are difficult to read. (I've been testing on Mac). |
|
@astellhorn will take a look on it |
wpotrzebowski
removed
the
Discuss At The Call
|
See comments issue #2570 |
wpotrzebowski
approved these changes
Sep 12, 2023
wpotrzebowski
deleted the
2588-fixing-BoxInteractor-method-signature-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes the mismatch between the
_post_datamethod signatures in BoxInteractor and WedgeInteractor and their child classes. It also removes an unnecessary argument from one_post_datacall, as it only sets a parameter to its default value. This fixes an error that occurs when the 'fold' setting is changed in Box Interactor X and Box Interactor Y's Slicer Parameters menu.Fixes #2588
How Has This Been Tested?
The check-box can now be checked and un-checked without causing the error, and the plot updates accordingly.
Review Checklist (please remove items if they don't apply):