Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2577 orientation viewer doesnt work from nigthly build on mac #2600

Conversation

lucas-wilkins
Copy link
Contributor

Fixed the orientation viewer parameters to align with that used by sasmodels.

Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and it works as expected (tested on Mac).

@lucas-wilkins lucas-wilkins merged commit 1f6e909 into main Sep 11, 2023
36 checks passed
@krzywon krzywon deleted the 2577-orientation-viewer-doesnt-work-from-nigthly-build-on-mac-1 branch September 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation Viewer doesn't work from nigthly build (on Mac)
2 participants